🔥 remove duplicate license file#1
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes a duplicate license file while also updating static analysis configuration, CI behavior, and dev dependency constraints.
Changes:
- Remove
LICENSE.md(keeping the existingLICENSEfile). - Update PHPStan config to include bleeding-edge rules.
- Bump dev tooling versions and tweak the GitHub Actions PHPStan job environment.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
phpstan.neon |
Adds PHPStan bleedingEdge.neon include. |
composer.json |
Updates dev dependency version constraints (PHP-CS-Fixer, PHPUnit). |
LICENSE.md |
Deletes the duplicate MIT license file. |
.github/workflows/build.yaml |
Removes REQUIRE_DEV env from the PHPStan action invocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - run: | | ||
| sed -e :a -e '$d;N;2,3ba' -e 'P;D' phpstan.neon > phpstan2.neon && mv phpstan2.neon phpstan.neon | ||
| - name: PHPStan | ||
| uses: docker://oskarstark/phpstan-ga |
There was a problem hiding this comment.
The PHPStan job no longer sets REQUIRE_DEV: true, and there is no explicit composer install step in this job. If oskarstark/phpstan-ga defaults to installing dependencies without dev packages, the analysis may fail because phpstan.neon includes files under vendor/ (e.g., strict rules / bleedingEdge). Either restore REQUIRE_DEV: true or add an explicit dependency install step that includes dev dependencies so the referenced vendor/ files are present.
| uses: docker://oskarstark/phpstan-ga | |
| args: analyse | |
| env: | |
| REQUIRE_DEV: true |
No description provided.